[ 
https://issues.apache.org/jira/browse/CURATOR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561323#comment-16561323
 ] 

mskonovalov commented on CURATOR-472:
-------------------------------------

And honestly I have another issue with this method in ZK in StaticHostProvider.

 

We have a high concurrent system and if ZK is not available I want to fail 
fast. But they have hardcoded 1000ms timeout here so call with 3 retries takes 
about 4.5 sec even if I pass all the timeouts ~100ms.

> Test-only code started to be called in prod
> -------------------------------------------
>
>                 Key: CURATOR-472
>                 URL: https://issues.apache.org/jira/browse/CURATOR-472
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Client
>            Reporter: mskonovalov
>            Assignee: Cameron McKenzie
>            Priority: Critical
>
> After commit {{fe2c7c4cd606c0cf4bc4fab15deedc0f4c33ea0e}} the method
>  
> {code:java}
> protected boolean testableWaitForShutdown(int wait)
>     throws InterruptedException
> {code}
> with the following comment
>  
>  
> {code:java}
> * Wait up to wait milliseconds for the underlying threads to shutdown.
> * THIS METHOD IS EXPECTED TO BE USED FOR TESTING ONLY!!!
> {code}
> started to be called from real method {{ZooKeeper.close()}}
> It prevents tests to finish.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to