[ https://issues.apache.org/jira/browse/CURATOR-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624963#comment-16624963 ]
ASF GitHub Bot commented on CURATOR-477: ---------------------------------------- Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/278#discussion_r219688441 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java --- @@ -165,6 +167,18 @@ public Builder setCreateParentNodes(boolean createParentNodes) return this; } + /** + * By default, TreeCache creates {@link org.apache.zookeeper.ZooKeeper} watches for every created path. + * Change this behavior with this method. + * @param createZkWatches true to create watches + * @return this for chaining + */ + public Builder setCreateZkWatches(boolean createZkWatches) + { + this.createZkWatches = createZkWatches; + return this; + } --- End diff -- and e.g. disableZkWatches(boolean) > Ability to turn off Zk Watches in Curator Framework > --------------------------------------------------- > > Key: CURATOR-477 > URL: https://issues.apache.org/jira/browse/CURATOR-477 > Project: Apache Curator > Issue Type: Improvement > Components: Framework > Affects Versions: 4.0.1 > Reporter: Rama Chavali > Priority: Major > > In our use case, we use *{{TreeCache}}* to get Zk Data periodically. We start > *{{TreeCache}}* read data and close it. In this use case, The > {{ZkWatchManager}} of {{ZooKeeper}} class keeps growing for every TreeCache > operation because new {{TreeNode}} objects are created and added there > leading to a memory leak. Also since we do not want the Watcher to > periodically watch, this creates unnecessary background operations. > Can we introduce a builder flag in CuratorFramework's Builder some thing > called "createZkWatches" that we can use to turn the watchers off? The > default would be set to true to retain the current behaviour. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)