GitHub user leventov opened a pull request:

    https://github.com/apache/curator/pull/301

    [CURATOR-503] Update dependencies in January 2019

    The main motivation for this update is updating Guava from 20.0 to 
27.0.1-jre. Between these versions, the implementation of 
`Maps.newConcurrentMap()` (this method is used in many some places in Curator 
code) was changed and now it returns `ConcurrentHashMap` instead of Guava's own 
implementation, that was less efficient.
    
    This PR also updates Jackson version, as well as #280, from 2.7 to 2.9. 
Answering questions raised in the comments to that PR: I believe upgrading 
Jackson from 2.7 to 2.9 is safe. The compatibility standards in Jackson are 
much higher than in an average Java project. Most incompatibilities in 
[2.8](https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8#changes-compatibility)
 and 
[2.9](https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9#changes-compatibility)
 are minor tweaks in Jackson's programmatic API (shouldn't be a concern as long 
as Curator is built and passes tests with the updated dependencies). Also 
support for some old Java and Android versions is dropped, shouldn't be a 
concern in Curator either. Finally, seems that there are the only two changes 
that affect serialization format: [of 
`java.nio.Path`](https://github.com/FasterXML/jackson-databind/issues/1235) and 
[of `java.sql.Date`](https://github.com/FasterXML/jackson-databind/issues/219). 
It also doe
 sn't seem to be relevant to Curator.
    
    Testing: `mvn test` in a private CI server passed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/metamx/curator update-deps-2018

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #301
    
----
commit 73ce867cbfd5b9ea04b20f43e81837881f23277f
Author: Roman Leventov <leventov.ru@...>
Date:   2018-12-11T18:38:13Z

    Update deps

----


---

Reply via email to