[
https://issues.apache.org/jira/browse/CURATOR-499?focusedWorklogId=206931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206931
]
ASF GitHub Bot logged work on CURATOR-499:
------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/19 19:29
Start Date: 03/Mar/19 19:29
Worklog Time Spent: 10m
Work Description: marquiswang commented on pull request #300: CURATOR-499
Allow creating sequential nodes with an empty name
URL: https://github.com/apache/curator/pull/300#discussion_r261882513
##########
File path:
curator-client/src/test/java/org/apache/curator/utils/TestZKPaths.java
##########
@@ -26,6 +26,18 @@
public class TestZKPaths
{
+ @Test
Review comment:
Sorry, I have been on an extended trip and have not had a chance to work on
this. I can definitely add tests when I get home in mid March.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 206931)
Time Spent: 40m (was: 0.5h)
> ZKPaths strips trailing "/" incorrectly when creating sequential nodes
> ----------------------------------------------------------------------
>
> Key: CURATOR-499
> URL: https://issues.apache.org/jira/browse/CURATOR-499
> Project: Apache Curator
> Issue Type: Bug
> Reporter: Marquis Wang
> Assignee: Jordan Zimmerman
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I think this was introduced in CURATOR-166, which changed ZKPaths to strip
> trailing slashes from child nodes.
> This is fine in most cases: it made it so
> {code:java}
> curatorFramework.create()
> .forPath("/path/to/node/", data);{code}
> would create a node at {{/path/to/node}}.
> However, if you want to create a sequential node:
> {code:java}
> curatorFramework.create()
> .withMode(CreateMode.PERSISTENT_SEQUENTIAL)
> .forPath("/path/to/node/", data);{code}
> In clients after CURATOR-166 (2.7.1 and higher), this will create a node
> {{/path/to/node00000001}}. Before, and if you call the zookeeper cli with the
> same options, it would create a node {{/path/to/node/00000001}}.
> This effectively makes it so you cannot use curator to create sequential
> nodes where the entire node name is the sequence number.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
