Right, it doesn't seem we have a pressing need for JDK 11. So, should re-build 4.2 with latest JDK 8? Seems like 4.2.0 was built with 11.
On Tue, May 28, 2019 at 1:55 AM Cameron McKenzie <[email protected]> wrote: > The argument for moving to JDK11 seems reasonable, but I'm not sure if > there's any pressing need for it? I would expect we'd just use the same JDK > as Zookeeper is building with? > > On Tue, May 28, 2019 at 4:20 AM Jordan Zimmerman < > [email protected]> wrote: > >> I'd be -1 on building with Java 11 at this point. Maybe other committers >> can chime in. >> >> -JZ >> >> > On May 27, 2019, at 1:16 PM, shay shimony <[email protected]> wrote: >> > >> > Hi, >> > Do you agree with Paco, that we should build with jdk 11(using >> --release 8)? >> > His reason seems reasonable. >> > If so, i can merge his changes and release new 4.2 build. >> > Thanks >> > >> > >> > On Wed, May 22, 2019, 17:33 Jordan Zimmerman < >> [email protected] <mailto:[email protected]>> wrote: >> > (moving to @dev - all communication should be on one of Curator's email >> addresses) >> > >> > Hmm - the manifest for the JAR at Maven central does show that. I'm not >> sure why. The classfile version is still 52 (Java 8) I just checked with >> javap >> > >> > Classfile >> jar:file:xxxxxxx/curator-framework-4.2.0.zip!/org/apache/curator/framework/CuratorFramework.class >> > Last modified Mar 3, 2019; size 4640 bytes >> > MD5 checksum 0b16620a7a82f836290510521dc5ee9a >> > Compiled from "CuratorFramework.java" >> > public interface org.apache.curator.framework.CuratorFramework extends >> java.io.Closeable >> > minor version: 0 >> > major version: 52 >> > >> > -Jordan >> > >> > P.S. We required Jira Issues for all PRs. I added a comment to that PR. >> > >> > >> >> On May 22, 2019, at 5:12 AM, shay shimony <[email protected] <mailto: >> [email protected]>> wrote: >> >> >> >> Hi Jordan, >> >> >> >> Regarding this pull request < >> https://github.com/apache/curator/pull/312>, was 4.2.0 built using jdk >> 11, as he said? >> >> If so, do you think we should re-build next release with the --release >> flag, as he suggests? >> >> This post < >> https://stackoverflow.com/questions/43102787/what-is-the-release-flag-in-the-java-9-compiler> >> says that it is not enough to use -source and -target, but need also >> -bootclasspath, or simply --release to do all 3. >> >> >> >> Where is this manifest that he mentioned, that shows this: >> >> Build-Jdk: 11.0.2 >> >> Built-By: jordanzimmerman >> >> >> >> located? >> >> >> >> From this JIRA <https://issues.apache.org/jira/browse/CURATOR-509> I >> understood that you switched to latest jdk 8. So I thought that you used >> that jdk to build 4.2.0. >> >> >> >> >> >> Thanks, >> >> Shay >> > >> >>
