shayshim commented on a change in pull request #315: [CURATOR-530]
Documentation on InterProcessSemaphoreMutex is misleading
URL: https://github.com/apache/curator/pull/315#discussion_r302164352
##########
File path:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/InterProcessMultiLock.java
##########
@@ -145,6 +145,9 @@ public boolean acquire(long time, TimeUnit unit) throws
Exception
* {@inheritDoc}
*
* <p>NOTE: locks are released in the reverse order that they were
acquired.</p>
+ *
+ * @throws Exception ZK errors, interruptions, current thread does not own
the lock
Review comment:
Seems right, but don't you need to add now same "@throws" text also for
InterProcessMutex.release()? (This is also the actual code that throws
IllegalMonitorStateException in case of different thread, and used internally
here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
