cammckenzie commented on a change in pull request #345: [CURATOR-551] Fix
Handle Holder new connection string
URL: https://github.com/apache/curator/pull/345#discussion_r377460199
##########
File path: curator-client/src/main/java/org/apache/curator/HandleHolder.java
##########
@@ -70,7 +61,16 @@ String getConnectionString()
String getNewConnectionString()
{
String helperConnectionString = (helper != null) ?
helper.getConnectionString() : null;
- return ((helperConnectionString != null) &&
!ensembleProvider.getConnectionString().equals(helperConnectionString)) ?
helperConnectionString : null;
+ String ensembleProviderConnectionString =
ensembleProvider.getConnectionString();
Review comment:
The whole flow of how things interact is very confusing, but I don't think
that this is an issue. `closeAndReset()` gets called from
`ConnectionState.reset()` which gets called from the `ConnectionState.start()`
method. I'm not 100% sure there's not a race condition here, but from what I
can see, it seems improbable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
