TisonKun commented on a change in pull request #335: [CURATOR-549] Recipes based on Persistent Recursive Watchers URL: https://github.com/apache/curator/pull/335#discussion_r398354417
########## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/CuratorCacheBuilder.java ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.curator.framework.recipes.cache; + +import java.util.concurrent.CompletableFuture; +import java.util.function.Consumer; +import java.util.function.Function; + +public interface CuratorCacheBuilder +{ + /** + * @param options any options + * @return this + */ + CuratorCacheBuilder withOptions(CuratorCache.Options... options); + + /** + * Alternate storage to use. If not specified, {@link StandardCuratorCacheStorage#standard()} is used + * + * @param storage storage instance to use + * @return this + */ + CuratorCacheBuilder withStorage(CuratorCacheStorage storage); + + /** + * By default any unexpected exception is handled by logging the exception. You can change + * so that a handler is called instead. Under normal circumstances, this shouldn't be necessary. + * + * @param exceptionHandler exception handler to use + */ + CuratorCacheBuilder withExceptionHandler(Consumer<Exception> exceptionHandler); + + /** + * Low-level replacement for runSafe. Listeners are notified by calling + * {@code runSafe(() -> listenerManager.forEach(...))}. This should work for nearly any + * case. However, you can provide a different handler instead so that runSafe is not + * used. The proc must behave similar to {@link org.apache.curator.framework.CuratorFramework#runSafe(Runnable)}. + * Under normal circumstances, this shouldn't be necessary. + * + * @param runSafeProc runSafe proc + * @return this + */ + CuratorCacheBuilder withListenerRunProc(Function<Runnable, CompletableFuture<Void>> runSafeProc); Review comment: Shall we add a test or example for the use case? I don't see the motivation here in practice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
