cammckenzie commented on a change in pull request #336: [CURATOR-549] Bridge facade for ModeledCache and ServiceCache, etc. URL: https://github.com/apache/curator/pull/336#discussion_r401898432
########## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/CuratorCacheBridgeBuilder.java ########## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.curator.framework.recipes.cache; + +import java.util.concurrent.ExecutorService; + +public interface CuratorCacheBridgeBuilder +{ + /** + * @param options any options + * @return this + */ + CuratorCacheBridgeBuilder withOptions(CuratorCache.Options... options); + + /** + * The bridge cache will not retain the data bytes. i.e. ChildData objects + * returned by the cache will always return {@code null} for {@link ChildData#getData()} + * + * @return this + */ + CuratorCacheBridgeBuilder withBytesNotCached(); Review comment: Any reason this is withBytesNotCached instead of withDataNotCached? Isn't the content of a child node referred to as data elsewhere in Curator? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
