[
https://issues.apache.org/jira/browse/CURATOR-568?focusedWorklogId=431451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431451
]
ASF GitHub Bot logged work on CURATOR-568:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/20 22:04
Start Date: 06/May/20 22:04
Worklog Time Spent: 10m
Work Description: cammckenzie commented on a change in pull request #364:
URL: https://github.com/apache/curator/pull/364#discussion_r421110702
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
##########
@@ -242,6 +244,29 @@ public Builder ensembleProvider(EnsembleProvider
ensembleProvider)
return this;
}
+ /**
+ * Allows to configure if the ensemble configuration changes will be
watched.
+ * The default value is {@code true}.<br>
+ *
+ * IMPORTANT: Use this method in combination with {@link
#ensembleProvider(EnsembleProvider)} to provide
+ * and instance that returns {@code false} on {@link
EnsembleProvider#updateServerListEnabled()} in order
Review comment:
typo: should be "an instance"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431451)
Time Spent: 0.5h (was: 20m)
> New option allowing CuratorFramework skip ZK ensemble tracking
> --------------------------------------------------------------
>
> Key: CURATOR-568
> URL: https://issues.apache.org/jira/browse/CURATOR-568
> Project: Apache Curator
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 4.3.0
> Reporter: Chevaris
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> CuratorFrameworkImpl lacks an option to skip Ensemble tracking.
> Proposal is to include a new option in CuratorFrameworkFactory.Builder that
> allows to skip ensemble tracking. This can be useful in certain scenarios in
> which CuratorFramework is accessing to ZK clusters via load balancer or
> Virtual IPs. In this case ensemble tracking is avoiding CuratorFramework to
> support this kind of connectivity.
> Proposal suggest including in CuratorFrameworkFactory.Builder 2 new methods:
> * ensembleTracker(boolean) that allows to enable / disable ensembleTracker.
> * withEnsembleTracker() that will return the value set via ensembleTracker
> method. If ensembleTracker was not used, then default value will return true
> for backwards compatibility.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
