Randgalt commented on a change in pull request #363:
URL: https://github.com/apache/curator/pull/363#discussion_r421174839



##########
File path: 
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
##########
@@ -637,7 +637,8 @@ boolean useContainerParentsIfAvailable()
         boolean doQueueOperation = false;
         do
         {
-            if ( RetryLoop.shouldRetry(event.getResultCode()) )
+            final KeeperException ke = 
KeeperException.create(event.getResultCode());

Review comment:
       nit - for me creating `ke` is unneeded. Create the exception directly as 
the argument




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to