[
https://issues.apache.org/jira/browse/CURATOR-574?focusedWorklogId=446606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446606
]
ASF GitHub Bot logged work on CURATOR-574:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/20 16:06
Start Date: 16/Jun/20 16:06
Worklog Time Spent: 10m
Work Description: eolivelli commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r440969485
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -78,7 +79,7 @@ private static ExecutorService
convertThreadFactory(ThreadFactory threadFactory)
this.discovery = discovery;
- String path = discovery.pathForName(name);
+ path = discovery.pathForName(name);
Review comment:
@Randgalt do you think this is a regression ?
I will push down the fix to CuratorCacheListener, thanks for the suggestion.
I didn't go that way because I wasn't sure.
It is important to understand if this is a regression in 5.0 and then we
have to fix it asap, otherwise applications will break
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 446606)
Time Spent: 0.5h (was: 20m)
> DiscoveryService fatal error on deserializing an empty byte[] as JSON
> ---------------------------------------------------------------------
>
> Key: CURATOR-574
> URL: https://issues.apache.org/jira/browse/CURATOR-574
> Project: Apache Curator
> Issue Type: Bug
> Components: Recipes
> Affects Versions: 5.0.0
> Reporter: Enrico Olivelli
> Priority: Critical
> Fix For: 5.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Below you can see the error in 5.0.0 tests, but I have seen this error on a
> client application. The error seems a blocker for the upgrade to 5.0.0
> {code}
> ERROR org.apache.curator.framework.listen.MappingListenerManager Listener
> (org.apache.curator.framework.recipes.cache.CuratorCacheListenerBuilderImpl$2@329dbdbf)
> threw an exception [Curator-SafeNotifyService-0]
> java.lang.RuntimeException: java.lang.RuntimeException:
> com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to
> map due to end-of-input
> at [Source: (byte[])""; line: 1, column: 0]
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCacheListenerWrapper.sendEvent(PathChildrenCacheListenerWrapper.java:75)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCacheListenerWrapper.event(PathChildrenCacheListenerWrapper.java:42)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheListenerBuilderImpl$2.lambda$event$0(CuratorCacheListenerBuilderImpl.java:149)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheListenerBuilderImpl$2.event(CuratorCacheListenerBuilderImpl.java:149)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheImpl.lambda$putStorage$7(CuratorCacheImpl.java:279)
> at
> org.apache.curator.framework.listen.MappingListenerManager.lambda$forEach$0(MappingListenerManager.java:92)
> at
> org.apache.curator.framework.listen.MappingListenerManager.forEach(MappingListenerManager.java:89)
> at
> org.apache.curator.framework.listen.StandardListenerManager.forEach(StandardListenerManager.java:89)
> at
> org.apache.curator.framework.recipes.cache.CuratorCacheImpl.lambda$callListeners$10(CuratorCacheImpl.java:293)
> at
> java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1800)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
> at java.base/java.lang.Thread.run(Thread.java:832)
> Caused by: java.lang.RuntimeException:
> com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to
> map due to end-of-input
> at [Source: (byte[])""; line: 1, column: 0]
> at
> org.apache.curator.x.discovery.details.ServiceCacheImpl.addInstance(ServiceCacheImpl.java:209)
> at
> org.apache.curator.x.discovery.details.ServiceCacheImpl.childEvent(ServiceCacheImpl.java:175)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCacheListenerWrapper.sendEvent(PathChildrenCacheListenerWrapper.java:71)
> ... 13 more
> Caused by: com.fasterxml.jackson.databind.exc.MismatchedInputException: No
> content to map due to end-of-input
> at [Source: (byte[])""; line: 1, column: 0]
> at
> com.fasterxml.jackson.databind.exc.MismatchedInputException.from(MismatchedInputException.java:59)
> at
> com.fasterxml.jackson.databind.ObjectMapper._initForReading(ObjectMapper.java:4344)
> at
> com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4189)
> at
> com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3300)
> at
> org.apache.curator.x.discovery.details.JsonInstanceSerializer.deserialize(JsonInstanceSerializer.java:86)
> at
> org.apache.curator.x.discovery.details.ServiceCacheImpl.addInstance(ServiceCacheImpl.java:204)
> ... 15 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
