I'm not opposed to it either. If we're already dependent on JUnit, then removing a dependency to another library doesn't seem like a bad thing.
So, +1 for me Tamas. cheers On Mon, Aug 10, 2020 at 7:47 AM Jordan Zimmerman <[email protected]> wrote: > Back when Curator was started, TestNG had many more features. If I were to > start from scratch today I'd use JUnit 5. But, I don't see much benefit in > changing now though I'm not opposed to it. > > -JZ > > > On Aug 9, 2020, at 12:42 AM, Enrico Olivelli <[email protected]> > wrote: > > > > Tamas > > > > Il Sab 8 Ago 2020, 21:40 Tamas Penzes <[email protected]> ha > > scritto: > > > >> Hi All, > >> > >> My jUnit5 migration on ZooKeeper is almost finished and thought it > would be > >> a good idea to do the same in Curator. > >> Curator uses testNG, which I don't know in details. > >> I've checked its page so I know it has some extra features, but I'm not > >> sure if we use any of them and if they are any not available in jUnit5. > >> > > > > I don't have a strong opinion here, but switching to some modern > framework > > would help in keeping the codebase clean and help new contributors. > > > > So +1 from my side. > > I will help you with reviews > > > > > > Enrico > > > > > >> So I'd like to ask you if it worths to migrate to jUnit5 or just > >> update Curator to use a newer version of testNG? > >> > >> Regards, Tamaas > >> > >
