eolivelli commented on a change in pull request #375:
URL: https://github.com/apache/curator/pull/375#discussion_r541554666



##########
File path: curator-examples/src/main/java/discovery/DiscoveryExample.java
##########
@@ -192,6 +194,14 @@ private static void 
listInstances(ServiceDiscovery<InstanceDetails> serviceDisco
                 }
             }
         }
+        catch ( Exception e )
+        {
+            if ( e instanceof KeeperException.NoNodeException )

Review comment:
       which instruction can throw this exception ? is it possible that it is 
throws inside the inner loop ? 
   in that case we could end the loop prematurely .
   that do you think ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to