jmslocum16 commented on pull request #376:
URL: https://github.com/apache/curator/pull/376#issuecomment-763709723
@cammckenzie Sorry for the delay on this - I was busy with work and the
holidays.
I just completed these changes, so they should be good for review whenever
is convenient for you. (And apologies for the size of the change, it was a
bigger change than anticipated even if ~2/3 of it is test code).
A couple follow-up notes after finishing my implementation:
- I realized that quietly() for deletes is the same as idempotent(), but I
still inherited the Idempotentable interface in DeleteBuilder and reused the
quietly() functionality to be consistent with Create and SetData.
- I didn't implement compareAndDelete or compareAndSetData since those
aren't as widely useful as the main Create/SetData/Delete. I could do so in a
new PR if desired.
- I did not add idempotent operations to the x-async framework, since this
change was already getting large and i'm not sure what the x-async framework is
used for. I could do that in a new PR if desired.
- I did not change any of the higher-level recipes to use idempotent
operations to simplify their implementation. I could do this in a new PR if
desired.
- I did not add idempotent operations to transactions, since I don't think
it makes sense to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
