[GitHub] [curator] TisonKun commented on a change in pull request #380: [CURATOR-590] Add option to disable parent creation for PersistentNode

[GitBox]

TisonKun commented on a change in pull request #380:
URL: https://github.com/apache/curator/pull/380#discussion_r589420209



##########
File path: 
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
##########
@@ -389,6 +410,7 @@ public void setData(byte[] data) throws Exception
     {
         data = Preconditions.checkNotNull(data, "data cannot be null");
         Preconditions.checkState(nodePath.get() != null, "initial create has 
not been processed. Call waitForInitialCreate() to ensure.");
+        Preconditions.checkState(!parentCreationFailure, "Parent recreation 
can't be achieved.");

Review comment:
       ```suggestion
           Preconditions.checkState(!parentCreationFailure, "Failed to create 
parent nodes.");
   ```
   
   Positive sentence.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org