[
https://issues.apache.org/jira/browse/CURATOR-599?focusedWorklogId=621523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621523
]
ASF GitHub Bot logged work on CURATOR-599:
------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/21 19:48
Start Date: 12/Jul/21 19:48
Worklog Time Spent: 10m
Work Description: eolivelli commented on a change in pull request #391:
URL: https://github.com/apache/curator/pull/391#discussion_r667773065
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java
##########
@@ -50,26 +59,24 @@
import org.apache.zookeeper.Watcher;
import org.apache.zookeeper.ZooDefs;
import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.client.ZKClientConfig;
import org.apache.zookeeper.data.ACL;
import org.apache.zookeeper.data.Stat;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.concurrent.ArrayBlockingQueue;
-import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.LinkedBlockingQueue;
-import java.util.concurrent.TimeUnit;
+import com.google.common.collect.Lists;
@SuppressWarnings("deprecation")
@Tag(CuratorTestBase.zk35TestCompatibilityGroup)
public class TestFramework extends BaseClassForTests
{
+ private final Logger log = LoggerFactory.getLogger(getClass());
Review comment:
Usually loggers are static fields
`private static final Logger log =
LoggerFactory.getLogger(TestFramework.class);`
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java
##########
@@ -50,26 +59,24 @@
import org.apache.zookeeper.Watcher;
import org.apache.zookeeper.ZooDefs;
import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.client.ZKClientConfig;
import org.apache.zookeeper.data.ACL;
import org.apache.zookeeper.data.Stat;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.concurrent.ArrayBlockingQueue;
-import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.LinkedBlockingQueue;
-import java.util.concurrent.TimeUnit;
+import com.google.common.collect.Lists;
@SuppressWarnings("deprecation")
@Tag(CuratorTestBase.zk35TestCompatibilityGroup)
public class TestFramework extends BaseClassForTests
{
+ private final Logger log = LoggerFactory.getLogger(getClass());
Review comment:
sorry.
you are right.
I forgot that we are in Curator and we have different conventions.
thanks for checking out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621523)
Time Spent: 2.5h (was: 2h 20m)
> Hanging indefinitely on some scenarios since zookeeper.request.timeout cannot
> be configured
> -------------------------------------------------------------------------------------------
>
> Key: CURATOR-599
> URL: https://issues.apache.org/jira/browse/CURATOR-599
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client
> Affects Versions: 5.1.0
> Reporter: Liran Mendelovich
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> On some executions where ZooKeeper server is not available, Curator client
> got waiting and hanging indefinitely, with thread dump stack trace which can
> be seen
> below.
> As this is not reproduced consistently, it seems like a race condition from
> Curator/ZooKeeper client, since zookeeper.request.timeout cannot be
> configured in Curator client.
> As a work-around solution, initialization is executed in a separate thread in
> order to interrupt it if it hangs. This has been identified and handled here:
> [join_while_zookeeper_down_issue|https://github.com/CiscoSE/commons-cluster/blob/main/docs/join_while_zookeeper_down_issue.txt]
> The wanted solution is expose configuration to be able to configure
> zookeeper.request.timeout, then it should wait until the request timeout,
> which is treated at org.apache.zookeeper.ClientCnxn.submitRequest().
>
> stacktrace size: 31
> java.lang.Object.wait(Native Method)
> java.lang.Object.wait(Object.java:502)
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1561)
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1533)
> org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1834)
> org.apache.curator.framework.imps.CreateBuilderImpl$16.call(CreateBuilderImpl.java:1131)
> org.apache.curator.framework.imps.CreateBuilderImpl$16.call(CreateBuilderImpl.java:1113)
> org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:93)
> org.apache.curator.framework.imps.CreateBuilderImpl.pathInForeground(CreateBuilderImpl.java:1110)
> org.apache.curator.framework.imps.CreateBuilderImpl.protectedPathInForeground(CreateBuilderImpl.java:593)
> org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:583)
> org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:48)
> org.apache.curator.x.discovery.details.ServiceDiscoveryImpl.internalRegisterService(ServiceDiscoveryImpl.java:237)
> org.apache.curator.x.discovery.details.ServiceDiscoveryImpl.reRegisterServices(ServiceDiscoveryImpl.java:456)
> org.apache.curator.x.discovery.details.ServiceDiscoveryImpl.start(ServiceDiscoveryImpl.java:135)
> ...
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
