I've taken a look at these and they all seem to be existing issues. How do people feel about releasing as is, and I'll add a Jira ticket to fix them before the next release? cheers
On Fri, Jul 23, 2021 at 9:25 PM Cameron McKenzie <[email protected]> wrote: > Hey Enrico, > What's apache-rat? Don't think I've used it before. I thought our build > had licensee checking in it already. Perhaps not? > > I can fix the problem and cut a new release but it probably won't be until > Monday. > Cheers > > > On Fri, 23 Jul 2021, 8:51 pm Enrico Olivelli, <[email protected]> wrote: > >> >> >> All tests passed, signature verified... >> >> I saw that apache-rat is failing, in particular the only problem is on a >> pom.xml file. >> >> Files with unapproved licenses: >> >> src/site/confluence/releases.confluence.vm >> curator-examples/src/main/java/pubsub/README.md >> curator-x-async/pom.xml >> curator-framework/src/test/resources/schema.yaml >> .travis.yml >> README.md >> >> Shall we fix the problem and cut a new release ? >> >> Enrico >> >> Il giorno gio 22 lug 2021 alle ore 00:38 Cameron McKenzie < >> [email protected]> ha scritto: >> >>> I didn't run them individually, I just ran 'mvn test' from the top >>> project >>> level and everything passed. >>> >>> [INFO] >>> [INFO] Apache Curator ..................................... SUCCESS [ >>> 9.396 s] >>> [INFO] Curator Testing .................................... SUCCESS [ >>> 6.068 s] >>> [INFO] Curator Client ..................................... SUCCESS [ >>> 23.540 s] >>> [INFO] Curator Framework .................................. SUCCESS >>> [10:58 >>> min] >>> [INFO] Curator Recipes .................................... SUCCESS >>> [27:46 >>> min] >>> [INFO] Curator Service Discovery .......................... SUCCESS [ >>> 53.625 s] >>> [INFO] Curator Async ...................................... SUCCESS >>> [02:17 >>> min] >>> [INFO] Curator Examples ................................... SUCCESS [ >>> 2.158 s] >>> [INFO] Curator Service Discovery Server ................... SUCCESS [ >>> 8.573 s] >>> [INFO] curator-test-zk35 .................................. SUCCESS >>> [10:23 >>> min] >>> >>> On Thu, Jul 22, 2021 at 8:35 AM Jordan Zimmerman < >>> [email protected]> >>> wrote: >>> >>> > Yeah - if I run separately they pass (I just tried it). I'm not sure if >>> > that's a concern or not. >>> > >>> > -JZ >>> > >>> > > On Jul 21, 2021, at 11:29 PM, Cameron McKenzie < >>> [email protected]> >>> > wrote: >>> > > >>> > > I just reran them locally on my machine and they all ran fine. >>> > > >>> > > On Wed, Jul 21, 2021 at 9:25 PM Jordan Zimmerman < >>> > [email protected]> >>> > > wrote: >>> > > >>> > >> I'm seeing consistent test failures with the Reconfig tests. Anyone >>> > else? >>> > >> >>> > >> [WARNING] Tests run: 18, Failures: 0, Errors: 0, Skipped: 2, Time >>> > elapsed: >>> > >> 7.239 s - in org.apache.curator.framework.imps.TestReconfiguration >>> > >> [INFO] Running org.apache.curator.framework.imps.TestReadOnly >>> > >> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time >>> elapsed: >>> > >> 52.81 s <<< FAILURE! - in >>> org.apache.curator.framework.imps.TestReadOnly >>> > >> [ERROR] >>> > >> >>> > >>> org.apache.curator.framework.imps.TestReadOnly.testConnectionStateNewClient >>> > >> Time elapsed: 47.603 s <<< ERROR! >>> > >> org.apache.zookeeper.KeeperException$ConnectionLossException: >>> > >> KeeperErrorCode = ConnectionLoss for / >>> > >> at >>> > >> >>> > >>> org.apache.curator.framework.imps.TestReadOnly.testConnectionStateNewClient(TestReadOnly.java:102) >>> > >> >>> > >> [INFO] Running org.apache.curator.framework.imps.TestReadOnly >>> > >> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time >>> elapsed: >>> > >> 44.3 s <<< FAILURE! - in >>> org.apache.curator.framework.imps.TestReadOnly >>> > >> [ERROR] >>> > >> >>> > >>> org.apache.curator.framework.imps.TestReadOnly.testConnectionStateNewClient >>> > >> Time elapsed: 44.299 s <<< ERROR! >>> > >> org.apache.zookeeper.KeeperException$ConnectionLossException: >>> > >> KeeperErrorCode = ConnectionLoss for / >>> > >> at >>> > >> >>> > >>> org.apache.curator.framework.imps.TestReadOnly.testConnectionStateNewClient(TestReadOnly.java:102) >>> > >> >>> > >> [INFO] Running org.apache.curator.framework.imps.TestReadOnly >>> > >> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time >>> elapsed: >>> > >> 45.204 s <<< FAILURE! - in >>> > org.apache.curator.framework.imps.TestReadOnly >>> > >> [ERROR] >>> > >> >>> > >>> org.apache.curator.framework.imps.TestReadOnly.testConnectionStateNewClient >>> > >> Time elapsed: 45.203 s <<< ERROR! >>> > >> org.apache.zookeeper.KeeperException$ConnectionLossException: >>> > >> KeeperErrorCode = ConnectionLoss for / >>> > >> at >>> > >> >>> > >>> org.apache.curator.framework.imps.TestReadOnly.testConnectionStateNewClient(TestReadOnly.java:102) >>> > >> >>> > >> -Jordan >>> > >> >>> > >> >>> > >>> On Jul 20, 2021, at 10:56 AM, Enrico Olivelli <[email protected] >>> > >>> > >> wrote: >>> > >>> >>> > >>> Cameron, >>> > >>> thank you for running the release >>> > >>> >>> > >>> I cannot find >>> https://dist.apache.org/repos/dist/dev/curator/5.2.0/ >>> > >>> >>> > >>> dist - Revision 48898: /dev/curator >>> > >>> >>> > >>> - .. <https://dist.apache.org/repos/dist/dev/> >>> > >>> - 5.1.0/ <https://dist.apache.org/repos/dist/dev/curator/5.1.0/> >>> > >>> >>> > >>> >>> > >>> Il giorno mar 20 lug 2021 alle ore 00:18 Cameron McKenzie < >>> > >>> [email protected]> ha scritto: >>> > >>> >>> > >>>> Hello, >>> > >>>> >>> > >>>> This is the vote for Apache Curator version 5.2.0 >>> > >>>> >>> > >>>> *** Please download, test and vote within approx. 72 hours >>> > >>>> >>> > >>>> Note that we are voting upon the source (tag) and binaries are >>> > provided >>> > >> for >>> > >>>> convenience. >>> > >>>> >>> > >>>> Link to release notes: >>> > >>>> >>> > >>>> >>> > >> >>> > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12348543 >>> > >>>> >>> > >>>> Staging repo: >>> > >>>> https://dist.apache.org/repos/dist/dev/curator/5.2.0/ >>> > >>>> >>> > >>>> Binary artifacts: >>> > >>>> >>> > >> >>> > >>> https://repository.apache.org/content/repositories/orgapachecurator-1051 >>> > >>>> >>> > >>>> The tag to be voted upon: >>> > >>>> >>> > >>>> >>> > >> >>> > >>> https://git-wip-us.apache.org/repos/asf?p=curator.git;a=commit;h=c1746faeeba88ae1df2340f0b492ac1c46306242 >>> > >>>> >>> > >>>> Curator's KEYS file containing PGP keys we use to sign the >>> release: >>> > >>>> https://www.apache.org/dist/curator/KEYS >>> > >>>> >>> > >>>> [ ] +1 approve >>> > >>>> [ ] +0 no opinion >>> > >>>> [ ] -1 disapprove (and reason why) >>> > >>>> >>> > >> >>> > >> >>> > >>> > >>> >>
