[
https://issues.apache.org/jira/browse/CURATOR-608?focusedWorklogId=633777&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633777
]
ASF GitHub Bot logged work on CURATOR-608:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 19:28
Start Date: 04/Aug/21 19:28
Worklog Time Spent: 10m
Work Description: Ryan0751 opened a new pull request #395:
URL: https://github.com/apache/curator/pull/395
Modified ZPathImpl's "isParameter()" method to properly check for parameters
strings (values inside of a pair parameter delimiters). This corrects issues
with checking for path resolution status in certain cases.
Modified ZPathImpl's "resolved()" method to allow for substituted parameters
to have leading path separators ("/"). This is useful in the case where a
parameter is used for the first node element in the path, eliminating the need
for the user to worry about the leading "/".
Added an additional unit test case for the leading "/" changes, and fixed
bugs in the basic test cases that were accepting the wrong resolved state of
tested ZPaths.
Fixed an old typo in one of the JavaDoc comments.
All unit tests for curator pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633777)
Remaining Estimate: 0h
Time Spent: 10m
> ZPath's check for "isParameter()" is too simplistic, leading to isResolved()
> false negatives
> --------------------------------------------------------------------------------------------
>
> Key: CURATOR-608
> URL: https://issues.apache.org/jira/browse/CURATOR-608
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 5.1.0
> Reporter: Ryan Ruel
> Priority: Major
> Fix For: 5.2.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ZPath's "isParameter()" method checks to see if an element of the path is a
> parameter which make be substituted (i.e, "\{param}").
> Today, the check merely looks to see if the string contains "/" and then some
> characters.
> Instead, it should check for the full parameter pattern.
> The check that is in place now can lead to ZPath's which appear fully
> resolved, but when isResolved() is called on the path are indicated as NOT
> resolved. This causes failures with certain ModeledFramework operations.
> For example:
> ZPath rootPath = ZPath.from("/root");
> ZPath path =
> ZPath.parseWithIds("\{root}/\{one}/two/\{three}").resolved(rootPath, "one",
> "three");
> This produces a fully resolved path: /root/one/two/three
> But calling "isResolved()" on the created path returns false.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
