[
https://issues.apache.org/jira/browse/CURATOR-609?focusedWorklogId=634627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634627
]
ASF GitHub Bot logged work on CURATOR-609:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/21 15:45
Start Date: 05/Aug/21 15:45
Worklog Time Spent: 10m
Work Description: Ryan0751 opened a new pull request #396:
URL: https://github.com/apache/curator/pull/396
On event type NODE_REMOVED, an additional check was added to ensure that the
ZNode actually contains data before attempting to deserialize it into a model.
If no model is present for the ZNode, the accept callback is not called (as
this is not a valid ModeledFramework object).
This is already accounted for with events NODE_ADDED/NODE_UPDATED, as there
was already a check for null data in the node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 634627)
Remaining Estimate: 0h
Time Spent: 10m
> ModeledCache attempts to deserialize empty ZNodes on deletion, resulting in
> exceptions
> --------------------------------------------------------------------------------------
>
> Key: CURATOR-609
> URL: https://issues.apache.org/jira/browse/CURATOR-609
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 5.1.0
> Reporter: Ryan Ruel
> Priority: Major
> Fix For: 5.2.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When using the ModeledCache implementation, when a ZPath is deleted the
> implementation assumes that all ZNodes in the path contain a valid instance
> of the Model.
> If intermediary paths have been created that do not contain a Model, the
> implementation is calling the Jackson deserialize method with null data,
> resulting in an exception.
> Instead, the code should ensure there is valid data present prior to
> attempting to deserialize and call the "accept()" (callback) method on action
> NODE_REMOVED.
> Example:
> TestModel child1 = new TestModel("d", "e", "f", 1, BigInteger.ONE);
> ZPath path1 = path.child("foo").child("bar").child("child1");
> try (CachedModeledFramework<TestModel> client = ModeledFramework.wrap(async,
> modelSpec).cached())
> { CountDownLatch latch = new CountDownLatch(1);
> client.listenable().addListener((t, p, s, m) -> latch.countDown());
> client.start(); complete(client.withPath(path1).set(child1));
> assertTrue(timing.awaitLatch(latch)); assertDoesNotThrow(() ->
> rawClient.delete().deletingChildrenIfNeeded().forPath(path.toString())); }
> After calling "delete()", an exception is thrown:
> ERROR
> org.apache.curator.x.async.modeled.TestCachedModeledFramework$$Lambda$409/0x0000000800e0c850
> Could not process cache message [Curator-SafeNotifyService-0]
> java.lang.IllegalArgumentException: argument "src" is null
> at
> com.fasterxml.jackson.databind.ObjectReader._assertNotNull(ObjectReader.java:2120)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
