Ryan0751 commented on a change in pull request #395:
URL: https://github.com/apache/curator/pull/395#discussion_r691170904
##########
File path:
curator-x-async/src/test/java/org/apache/curator/x/async/modeled/TestZPath.java
##########
@@ -57,11 +57,11 @@ public void testBasic()
assertFalse(path.startsWith(ZPath.root.child("two")));
ZPath checkIdLike = ZPath.parse("/one/{two}/three");
Review comment:
I see. That seemed like a bug to me, but I can see now when considering
the two methods the difference in contracts.
Perhaps additional documentation would be helpful here (which I'm happy to
help with).
In the parseWithId's method, I see a "TODO" comment without any explanation
of what remains to be done. Is this something we should address as well?
Do you concur that the original problem of having something like "/root" as
the first parameter should be considered valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
