tisonkun commented on code in PR #430:
URL: https://github.com/apache/curator/pull/430#discussion_r974852907
##########
curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderLatch.java:
##########
@@ -190,6 +190,12 @@ public void close() throws IOException
close(closeMode);
}
+ // for testing
Review Comment:
For me, `VisibleForTesting` can mean that this method can be used in
production but its visibility is wider than necessary for testing.
But it's fair enough to use `VisibleForTesting`. I don't want to make the
change now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
