tisonkun commented on code in PR #435:
URL: https://github.com/apache/curator/pull/435#discussion_r997037672
##########
curator-recipes/src/test/java/org/apache/curator/framework/recipes/barriers/TestDistributedBarrier.java:
##########
@@ -218,4 +230,48 @@ public Object call() throws Exception
client.close();
}
}
+
+ @Test
+ public void testIsSet() throws Exception
+ {
+ try (CuratorFramework client =
CuratorFrameworkFactory.newClient(server.getConnectString(), new
RetryOneTime(1))) {
+ client.start();
+
+ final DistributedBarrier barrier = new DistributedBarrier(client,
"/barrier");
+ barrier.setBarrier();
+
+ assertTrue(barrier.isSet());
+ }
+ }
+
+ @Test
+ public void testIsNotSet() throws Exception
+ {
+ try (CuratorFramework client =
CuratorFrameworkFactory.newClient(server.getConnectString(), new
RetryOneTime(1))) {
+ client.start();
+
+ final DistributedBarrier barrier = new DistributedBarrier(client,
"/barrier");
+ barrier.setBarrier();
+ barrier.removeBarrier();
+
+ assertFalse(barrier.isSet());
+ }
+ }
+
+ @Test
+ public void testWatchersRemoved() throws Exception
+ {
+ CuratorFramework client = mock(CuratorFramework.class);
+ WatcherRemoveCuratorFramework watcherRemoveClient =
mock(WatcherRemoveCuratorFramework.class);
+ ExistsBuilder existsBuilder =
mock(ExistsBuilder.class);
+
+
when(client.newWatcherRemoveCuratorFramework()).thenReturn(watcherRemoveClient);
+ when(watcherRemoveClient.checkExists()).thenReturn(existsBuilder);
+
when(existsBuilder.usingWatcher(any(Watcher.class))).thenReturn(existsBuilder);
+
+ final DistributedBarrier barrier = new DistributedBarrier(client,
"/barrier");
+ barrier.waitOnBarrier(1, TimeUnit.SECONDS);
+ verify(watcherRemoveClient, atLeastOnce()).removeWatchers();
+ }
Review Comment:
Perhaps add watches and verify the following events triggered:
* DataWatchRemoved
* ChildWatchRemoved
* PersistentWatchRemoved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
