+1 (binding) Signatures and checksum are correct Builds and all tests pass (Ubuntu 20.04)
On Sun, Oct 23, 2022 at 8:18 PM tison <[email protected]> wrote: > +1 (binding) > > I verified: > > 1. LICENSE and NOTICE exist. > But the year in the NOTICE file should be updated? I don't think it's a > blocker. > > 2. Sign and checksum are correct. > How do you verify checksum? From our current sha512 file format I have > to generate a new sha512 from the zip ball manually and diff the output. > Cannot use `sha512sum -c` to verify it conveniently. > > 3. Build and verify on Java 11. > There're several warnings about reflections, and also they're blockers > to being able to test under Java 17, which can be following improvements in > the next release :) > > Best, > tison. > > > Enrico Olivelli <[email protected]> 于2022年10月22日周六 17:45写道： > > > Il Sab 22 Ott 2022, 07:25 Jordan Zimmerman <[email protected]> > ha > > scritto: > > > > > I’m away for the next few days. I can prep my vote on Monday if it > isn’t > > > too late. > > > > > > > > No hurry > > > > Thanks for letting us know > > > > Enrico > > > > > > > > > > > ==================== > > > Jordan Zimmerman > > > > > > > On Oct 21, 2022, at 9:09 AM, Enrico Olivelli <[email protected]> > > > wrote: > > > > > > > > Hello, > > > > > > > > This is the vote for Apache Curator version 5.4.0. > > > > See below the list of changes, the most notable chance is the upgrade > > > > of ZooKeeper to 3.7.1. > > > > > > > > > > > > *** Please download, test and vote within approx. 72 hours > > > > > > > > Note that we are voting upon the source (tag) and binaries are > > > > provided for convenience. > > > > > > > > Link to release notes: > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12352051 > > > > > > > > Staging repo: > > > > https://dist.apache.org/repos/dist/dev/curator/5.4.0/ > > > > > > > > Binary artifacts: > > > > > > https://repository.apache.org/content/repositories/orgapachecurator-1054 > > > > > > > > The tag to be voted upon: > > > > https://github.com/apache/curator/releases/tag/apache-curator-5.4.0 > > > > > > > > Curator's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/curator/KEYS > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Changes: > > > > > > > > > > > > ** Bug > > > > * [CURATOR-578] - EnsembleTracker replace hostname connectString > > > > with wrong ip from zk config > > > > * [CURATOR-597] - Background exception was not retry-able or retry > > > gave up > > > > * [CURATOR-638] - Curator disconnect from zookeeper when IPs > change > > > > * [CURATOR-644] - CLONE - Race conditions in LeaderLatch after > > > > reconnecting to ensemble > > > > * [CURATOR-645] - LeaderLatch generates infinite loop with two > > > > LeaderLatch instances competing for the leadership > > > > * [CURATOR-648] - CuratorFramework#blockUntilConnected does now > > > > wait forever if waitTime <= 0 > > > > * [CURATOR-649] - Background exception was not retry-able or retry > > > gave up > > > > > > > > > > > > > > > > > > > > ** Improvement > > > > * [CURATOR-458] - Fix Schema constructor validation logic > > > > * [CURATOR-587] - Use ZooKeeper 3.7+ ZooKeeperServerEmbedded in > > > > order to start TestingServer > > > > * [CURATOR-642] - Upgrade Guava to 31.1 > > > > * [CURATOR-646] - Fix RAT failure reports and add a CI task to > > > > prevent regression > > > > > > > > > > > > ** Wish > > > > * [CURATOR-596] - Upgrade ZooKeeper to 3.7.1 > > > > > > > > ** Task > > > > * [CURATOR-524] - Apache is asking us to review our build files > > > > and make sure we're using https for all URLs. > > > > * [CURATOR-653] - Double leader for LeaderLatch > > > > > > > > > > > > > > > > > > > > Best regards > > > > Enrico Olivelli > > > > > >
