kezhuw commented on code in PR #421:
URL: https://github.com/apache/curator/pull/421#discussion_r1112514697
##########
curator-test/src/main/java/org/apache/curator/test/InstanceSpec.java:
##########
@@ -205,6 +205,10 @@ public int getQuorumPort()
return quorumPort;
}
+ /**
+ * @deprecated use {@link TestingServer#getConnectString()} or {@link
TestingCluster#getConnectString()} instead
+ */
+ @Deprecated
Review Comment:
Actually, this pr mixed two things: CURATOR-535 and bring back
`TestTestingServer#setCustomTickTimeTest` for #383.
`ZooKeeperMainFace#getConfig` was introduced in #434, and its sole external
usage in `TestTestingServer#setCustomTickTimeTest` undermines #383.
Comparing to public `InstanceSpec`, I think `ZooKeeperMainFace` is more like
an internal concept. May be we can restrict visibility of `ZooKeeperMainFace`
to package ? This should solve all above concerns if make sense to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
