[jira] [Commented] (CURATOR-665) ModeledFramework does not throw expected exception and instead hangs

[Zili Chen (Jira)]

    [ 
https://issues.apache.org/jira/browse/CURATOR-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706723#comment-17706723
 ] 

Zili Chen commented on CURATOR-665:
-----------------------------------

Hi [~Ryan0751]!

Can you provide a reproduce sample and ensure that you're using 5.4.0?

I write a test case on master 
{{org.apache.curator.x.async.modeled.TestModeledFramework#testAcl}} and it 
throws exception as expected:


{code:java}
        try (CuratorFramework noAuthCurator = 
CuratorFrameworkFactory.builder().connectString(server.getConnectString()).retryPolicy(new
 RetryOneTime(1)).build())
        {
            noAuthCurator.start();
            ModeledFramework<TestModel> authClient = 
ModeledFramework.wrap(AsyncCuratorFramework.wrap(noAuthCurator), aclModelSpec);
            authClient.update(new TestModel("John", "Galt", "Galt's Gulch", 42, 
BigInteger.valueOf(66))).toCompletableFuture().get();
        }
{code}


> ModeledFramework does not throw expected exception and instead hangs
> --------------------------------------------------------------------
>
>                 Key: CURATOR-665
>                 URL: https://issues.apache.org/jira/browse/CURATOR-665
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.4.0
>            Reporter: Ryan Ruel
>            Priority: Major
>
> When writing data to ZooKeeper via Curator, I found that when I was receiving 
> a KeeperException NoAuth back from ZooKeeper, my call would hang indefinitely.
> The NoAuth was expected as I was testing writing to a path where the ACL was 
> set to prevent my client from writing (X509 authentication scheme).
> The call which hangs:
> {code:java}
> myFramework.set(myModel).toCompletableFuture().get();{code}
> The logs from the call:
> {code:java}
> 2023-03-29 14:20:29,511 [Curator-Framework-0] ERROR imps.CuratorFrameworkImpl 
> - Background exception was not retry-able or retry gave up
> org.apache.zookeeper.KeeperException$NoAuthException: KeeperErrorCode = 
> NoAuth for /test/foo {code}
> I'd expect this exception to bubble up wrapped in a CompletionException.
> Instead, CuratorFrameworkImpl just logs the exception and then the call to 
> get() hangs indefinitely.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)