Hi tison, > Curator's libs supports Java 8 for backward compatibility. It's not required for development. I suggest we don't lock ourselves in Java 8 when developing.
Previously, I was worried about potential linkage problems(e.g. compile to source level java 8 but linked to sdks above 8). But after reading JEP-247[1], I think "--release"(e.g. profile jdk-9-plus) is enough for us in both developing and releasing. [1]: https://openjdk.org/jeps/247 Best, Kezhu Wang On Mon, May 22, 2023 at 3:27 PM tison <[email protected]> wrote: > > Hi Kezhu, > > Thanks for looking into this proposal! Comments inline > > > Both spotless and palantir do not support java 8. Possible minimum java > 11. I don't have java 9 and java 10 installed. > > Curator's libs supports Java 8 for backward compatibility. It's not > required for development. I suggest we don't lock ourselves in Java 8 when > developing. > > > No maven integration to validate/verify lifecycles > > There is. It calls "check" so you can run "./mvnw spotless:check". Style > violations will fail our CI workflow, don't worry. > > > palantir[1] has only IntelliJ plugin, I found no other IDEs listed. > > It's not a regression and I suggest anyone can use his/her favorite style > when writing code. Just format to the consistent format before we merge it, > so that we don't have style-only code diff. > > > I suggest we add a section for developers in README to guide environment > setup and check > > Make sense. I'll add a section for it. > > I'm thinking of refactoring our website a bit but it can be another topic > that I expect to finish in two or three months. Then we merge all docs in > one place and catch up morden development tools. > > > there are jiras related to this. I think we could supersede them > > Thanks! I'll leave comments there. > > > Besides above, will this go to a VOTE ? We need a community consensus on > this. > > Definitely. This is why I start a discussion here. The next step will be a > vote if we reach a lazy consensus. > > Best, > tison.
