jira-importer commented on issue #548: URL: https://github.com/apache/curator/issues/548#issuecomment-2604694433
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt";>randgalt</a>:</i> <p>Comments on the patch:</p> <ul> <li>I usually use executorService.shutdownNow() instead of executorService.shutdown(). If shutdown is being called it usually means executing tasks shouldn't complete but instead be interrupted. Thoughts?</li> </ul> <ul> <li>nitpick: referencing instance fields via "this." is unnecessary and confusing.</li> </ul> <ul> <li>PathChildrenCache line 144 - why isn't "true" passed for shutdown in CloseableExecutorService?</li> </ul> <ul> <li>Looks like the pom change to exclude IDEA files got merged into this patch. It shouldn't be.</li> </ul> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
