jira-importer commented on issue #551: URL: https://github.com/apache/curator/issues/551#issuecomment-2604694839
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt";>randgalt</a>:</i> <p>Looks good. A few things though:</p> <ul> <li>deletingChildrenIfNeeded() should also support guaranteed(). This makes writing the fluent ifaces a lot more work. deletingChildrenIfNeeded() will need to be moved into a separate interface, etc.</li> </ul> <ul> <li>The static deleteChildren() method uses the raw ZooKeeper handle. Instead it should use a CuratorFramework handle so that retries, etc. are used.</li> </ul> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
