jira-importer commented on issue #554: URL: https://github.com/apache/curator/issues/554#issuecomment-2604695621
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot">githubbot</a>:</i> <p>Github user cammckenzie commented on the pull request:</p> <p> <a href="https://github.com/apache/curator/pull/17#issuecomment-50111927" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/curator/pull/17#issuecomment-50111927</a></p> <p> Overall, looks really good. I've made a few minor comments. My only other comment would be that it would be nice to see some more unit tests specific to a multi level cache. It's good that the TreeCache works against all of the PathChildrenCache tests, but I could only see 1 test that specifically deals with data with a depth > 2.</p> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org