+1 SGTM. Best, tison.
Kezhu Wang <kez...@apache.org> 于2025年6月23日周一 12:01写道: > > Hi all, > > I would like to release a new curator version for issues: > 1. Compatibility with zookeeper 3.9.3, see ZOOKEEPER-4936[1]. > ZooKeeper 3.9.3 changes `ZooKeeper::shutdown(boolean fullyShutDown)` > to `final` in ZOOKEEPER-4712. This breaks compilation of curator as we > override it to do custom logic in `TestingZooKeeperMain`. We have > fixes this in gh-1252[2]. > 2. gh-1259[3] reports that "PersistentWatcher no longer be used with > namespaced CuratorFramework instance". It was introduced in 5.8.0 and > has been fixed in gh-1262[4]. > > I expect the version would be 5.9.0 as gh-1250[5] and gh-1257[6] are > not bug fixes. > > Best, > Kezhu Wang > > [1]: https://issues.apache.org/jira/browse/ZOOKEEPER-4936 > [2]: https://github.com/apache/curator/pull/1252 > [3]: https://github.com/apache/curator/issues/1259 > [4]: https://github.com/apache/curator/pull/1262 > [5]: https://github.com/apache/curator/pull/1250 > [6]: https://github.com/apache/curator/pull/1257