[ 
https://issues.apache.org/jira/browse/CURATOR-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649781#comment-13649781
 ] 

Eric Tschetter commented on CURATOR-21:
---------------------------------------

Ah, yes, I was thinking that the refresh operation made it up to date as of the 
end of the operation, but it makes sense that it's only up-to-date as of the 
beginning of the operation, so it does need to queue up other refreshes that 
come while it is operating.

I'll check out the branch
                
> PathChildrenCache consumes an entire thread all the time no matter what
> -----------------------------------------------------------------------
>
>                 Key: CURATOR-21
>                 URL: https://issues.apache.org/jira/browse/CURATOR-21
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.0.0
>            Reporter: Eric Tschetter
>            Assignee: Jordan Zimmerman
>         Attachments: CURATOR-21-docs.patch, 
> CURATOR-21-Fix_watcher_race.patch, CURATOR-21.patch
>
>
> PathChildrenCache currently takes an Executor, but only to fire off a 
> Runnable that does a blocking while loop waiting for work.  This means that 
> you must have one thread per PathChildrenCache, which is not that great.
> PathChildrenCache should just use the Executor's work queuing mechanism to 
> enqueue work items instead of maintaining its own work queue mechanism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to