[
https://issues.apache.org/jira/browse/CURATOR-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated CURATOR-5:
-----------------------------------
Fix Version/s: (was: 2.0.2-incubating)
> Make JsonInstanceSerializer#deserialize leverage ServiceInstanceBuilder
> -----------------------------------------------------------------------
>
> Key: CURATOR-5
> URL: https://issues.apache.org/jira/browse/CURATOR-5
> Project: Apache Curator
> Issue Type: Improvement
> Components: Recipes
> Affects Versions: 2.0.0-incubating
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Minor
>
> From https://github.com/Netflix/curator/pull/255
> Proposing a way to change JsonInstanceSerializer leverage ServiceInstance's
> builder pattern directly.
> See discussion and request to generate a patch here:
> https://groups.google.com/d/topic/curator-users/Ai9RsVoUdgU/discussion
> ===
> It's possible a lot of the lower-level JSON deserialization code in
> JsonInstanceSerializer#deserialize() could be passed off to Jackson if
> ServiceInstanceBuilder's setters also followed the bean patterns (e.g.
> setId() versus id()). If ServiceInstanceBuilder followed this pattern,
> Jackson's standard bean deserialization could, I believe, deserialize
> directly into the ServiceInstanceBuilder and
> JsonInstanceSerializer#deserialize() could use that higher-level pattern to
> eliminate a fair chunk of code here.
> ===
> So, why don't we make ServiceInstanceBuilder follow the bean API? Can you
> update this pull to reflect that? I suggest leaving the old builder-style
> methods and marking them as deprecated. This way it won't break existing
> users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
