[
https://issues.apache.org/jira/browse/CURATOR-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin Morelli updated CURATOR-39:
---------------------------------
Description:
This may simple be an issue on my end, but I believe it to be an issue in
Curator. I'm using 2.0.1-incubating, using the following to build a
ServiceProvider:
serviceProvider = serviceDiscovery.serviceProviderBuilder()
.serviceName(name)
.providerStrategy(new
RoundRobinStrategy<DiscoverableService>())
.build();
serviceProvider.start();
I have a name => ServiceProvider map that stores all my service providers.
During shutdown, I call:
for (ServiceProvider serviceProvider : serviceProviderMap.values()) {
serviceProvider.close();
}
serviceDiscovery.close();
Which is redundant, it seems, because serviceDiscovery itself appears to
shutdown the providers. However, I still end up with a dangling
"ServiceProvider-0" thread that keeps Tomcat open.
If I start the container up, without making a service call (so I don't allocate
any ServiceProviders), Tomcat shuts down cleanly. As soon as a ServiceProvider
is allocated (by making a service call) Tomcat hangs during shutdown, and
informs me of the remaining thread. I will try to provide more information as
it becomes available to me.
was:
This may simple be an issue on my end, but I believe it to be an issue in
Curator. I'm using 2.0.1-incubating, using the following to build a
ServiceProvider:
{code}serviceProvider = serviceDiscovery.serviceProviderBuilder()
.serviceName(name)
.providerStrategy(new
RoundRobinStrategy<DiscoverableService>())
.build();
serviceProvider.start();{code}
I have a name => ServiceProvider map that stores all my service providers.
During shutdown, I call:
for (ServiceProvider serviceProvider : serviceProviderMap.values()) {
serviceProvider.close();
}
serviceDiscovery.close();
Which is redundant, it seems, because serviceDiscovery itself appears to
shutdown the providers. However, I still end up with a dangling
"ServiceProvider-0" thread that keeps Tomcat open.
If I start the container up, without making a service call (so I don't allocate
any ServiceProviders), Tomcat shuts down cleanly. As soon as a ServiceProvider
is allocated (by making a service call) Tomcat hangs during shutdown, and
informs me of the remaining thread. I will try to provide more information as
it becomes available to me.
> ServiceProvider thread is not closed during ServiceDiscovery close
> ------------------------------------------------------------------
>
> Key: CURATOR-39
> URL: https://issues.apache.org/jira/browse/CURATOR-39
> Project: Apache Curator
> Issue Type: Bug
> Reporter: Colin Morelli
> Assignee: Jordan Zimmerman
>
> This may simple be an issue on my end, but I believe it to be an issue in
> Curator. I'm using 2.0.1-incubating, using the following to build a
> ServiceProvider:
> serviceProvider = serviceDiscovery.serviceProviderBuilder()
> .serviceName(name)
> .providerStrategy(new
> RoundRobinStrategy<DiscoverableService>())
> .build();
> serviceProvider.start();
> I have a name => ServiceProvider map that stores all my service providers.
> During shutdown, I call:
> for (ServiceProvider serviceProvider : serviceProviderMap.values()) {
> serviceProvider.close();
> }
> serviceDiscovery.close();
> Which is redundant, it seems, because serviceDiscovery itself appears to
> shutdown the providers. However, I still end up with a dangling
> "ServiceProvider-0" thread that keeps Tomcat open.
> If I start the container up, without making a service call (so I don't
> allocate any ServiceProviders), Tomcat shuts down cleanly. As soon as a
> ServiceProvider is allocated (by making a service call) Tomcat hangs during
> shutdown, and informs me of the remaining thread. I will try to provide more
> information as it becomes available to me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
