deki commented on a change in pull request #324: RFC introduced: Supress
generated date switch for wsdl2java
URL: https://github.com/apache/cxf/pull/324#discussion_r155334050
##########
File path:
tools/wsdlto/databinding/jaxb/src/main/java/org/apache/cxf/tools/wsdlto/databinding/jaxb/JAXBDataBinding.java
##########
@@ -437,24 +437,20 @@ public void initialize(ToolContext c) throws
ToolException {
throw new ToolException(e);
}
}
- addSchemas(opts, schemaCompiler, schemas);
- addBindingFiles(opts, jaxbBindings, schemas);
-
- for (String ns : context.getNamespacePackageMap().keySet()) {
- File file = JAXBUtils.getPackageMappingSchemaBindingFile(ns,
context.mapPackageName(ns));
+ if (context.optionSet(ToolConstants.CFG_SUPPRESS_GENERATED_DATE)) {
+ // Prevents dumping current date as part of javadocs of the Java
files generated.
+ // This is done by passing '-suppress-generated-date' attribute to
jaxb xjc.
Review comment:
XJC has no such option, why should we pass it? After removing this codeblock
the test still passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
