reta commented on a change in pull request #851:
URL: https://github.com/apache/cxf/pull/851#discussion_r712580437
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java
##########
@@ -418,7 +418,7 @@ private Link makeAbsoluteLink(Link link) {
public <T> T doReadEntity(Class<T> cls, Type t, Annotation[] anns)
throws ProcessingException, IllegalStateException {
- return doReadEntity(cls, t, anns, false);
+ return doReadEntity(cls, t, anns,
!InputStream.class.isAssignableFrom(cls));
Review comment:
@andymc12 I think I nailed it down. In refactoring, we have lost the
semantics of the `response.stream.auto.close` property (it was only taking into
account in some specific flow). Also, I think the default auto-close detection
mechanism is good enough to not requiring manual should/should not close
instructions. The builds are green, what do you think about this one? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
