ffang commented on code in PR #937:
URL: https://github.com/apache/cxf/pull/937#discussion_r853395945


##########
rt/management/pom.xml:
##########
@@ -156,18 +156,6 @@
                             </execution>
                         </executions>
                     </plugin>
-                    <plugin>

Review Comment:
   Hi @jimma ,
   
   Please change as this way
   ```
   <configuration>
                                <obrRepository>NONE</obrRepository>
                                <instructions>
   -                                
<Export-Package>org.apache.cxf.management*,org.apache.cxf.tracing*</Export-Package>
   +                                <Export-Package>
   +                                                
org.apache.cxf.management.counters,
   +                                                
org.apache.cxf.management.interceptor,
   +                                                
org.apache.cxf.management.persistence,
   +                                                
org.apache.cxf.management.utils,
   +                                                
org.apache.cxf.management.jmx,
   +                                                
org.apache.cxf.management.jmx.export.runtime,
   +                                                org.apache.cxf.tracing*
   +                                </Export-Package>
                                </instructions>
                                <niceManifest>true</niceManifest>
                            </configuration>
   ```
   
   The root cause of this issue is that the previous org.apache.cxf.management* 
isn't specific enough, it include package from core, we should use the more 
fine-grained export package of cxf-rt-management module to avoid it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to