reta commented on code in PR #945:
URL: https://github.com/apache/cxf/pull/945#discussion_r867149920


##########
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/osgi/Activator.java:
##########
@@ -71,6 +74,14 @@ public void updated(Dictionary config) throws 
ConfigurationException {
             Long inMemThreshold = Long.valueOf(getValue(config, 
"inMemThresHold", "-1"));
             Boolean logMultipart = Boolean.valueOf(getValue(config, 
"logMultipart", "true"));
             Boolean logBinary = Boolean.valueOf(getValue(config, "logBinary", 
"false"));
+            Set<String> sensitiveElementNames = new HashSet<>(
+                    Arrays.asList(
+                            String.valueOf(getValue(config, 
"sensitiveElementNames", ""))

Review Comment:
   Could we please trim the values here to eliminate leading / trailing spaces 
issue:
   
   ```
   Arrays
       .stream(String.valueOf(getValue(config, "sensitiveElementNames", 
"").split(","))
       .map(String::trim)
       .filter(not(Srtring::isEmpty))
       .collect(Collectors.toSet());
   ``` 
   
   Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to