reta commented on code in PR #946: URL: https://github.com/apache/cxf/pull/946#discussion_r884171454
########## tools/compiler/src/main/java/org/apache/cxf/tools/compiler/Compiler.java: ########## @@ -17,7 +17,7 @@ * under the License. */ -package org.apache.cxf.common.util; Review Comment: Could we please keep the same package? I understand that we would have package split brain but this is public API and if we want this change into 3.4.x / 3.5.x / 3.6.x, we should not break the possible consumers. Alternatively, we could keep package change BUT introduce `org.apache.cxf.common.util.Compiler` class which will delegate to `org.apache.cxf.tools.compiler.Compiler`: it seems like public API is not using any dependencies from `java.compiler` APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
