reta commented on code in PR #954:
URL: https://github.com/apache/cxf/pull/954#discussion_r894954105
##########
rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java:
##########
@@ -42,7 +42,11 @@ public List<Endpoint> getAlternateEndpoints(Exchange
exchange) {
}
protected <T> T getNextAlternate(List<T> alternates) {
- return stillTheSameAddress() ? alternates.get(0) :
alternates.remove(0);
+ // is the amount of retries for the first alternate already exceeded?
+ if (!stillTheSameAddress()) {
+ alternates.remove(0);
+ }
+ return alternates.isEmpty() ? null : alternates.get(0);
Review Comment:
> This won't work for me, as I actually use this strategy with only one
endpoint, so I would always run into the edge case.
Agree. Just a suggestion, in this case you actually have an easy workaround
(not a solution, just temporary shortcut): reduce the number of max retries by
1. I will try to look for a better fix meantime, will update you shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
