reta commented on code in PR #1022:
URL: https://github.com/apache/cxf/pull/1022#discussion_r1016671480
##########
distribution/src/main/release/samples/pom.xml:
##########
@@ -240,108 +289,8 @@
</pluginRepository>
</pluginRepositories>
</profile>
- <profile>
- <id>java9-plus</id>
- <activation>
- <jdk>[9,)</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>jakarta.xml.bind</groupId>
- <artifactId>jakarta.xml.bind-api</artifactId>
- </dependency>
- <dependency>
- <groupId>jakarta.annotation</groupId>
- <artifactId>jakarta.annotation-api</artifactId>
- </dependency>
- <dependency>
- <groupId>jakarta.xml.ws</groupId>
- <artifactId>jakarta.xml.ws-api</artifactId>
- </dependency>
- <dependency>
- <groupId>jakarta.activation</groupId>
- <artifactId>jakarta.activation-api</artifactId>
- <version>2.1.0</version>
- </dependency>
- <dependency>
- <groupId>jakarta.jws</groupId>
- <artifactId>jakarta.jws-api</artifactId>
- </dependency>
- <dependency>
- <groupId>com.sun.xml.messaging.saaj</groupId>
- <artifactId>saaj-impl</artifactId>
- <version>2.0.1</version>
- <scope>runtime</scope>
- </dependency>
- <dependency>
- <groupId>org.glassfish.jaxb</groupId>
- <artifactId>jaxb-runtime</artifactId>
- </dependency>
- <dependency>
- <groupId>org.glassfish.jaxb</groupId>
- <artifactId>jaxb-xjc</artifactId>
- </dependency>
- <dependency>
- <groupId>org.glassfish.corba</groupId>
- <artifactId>glassfish-corba-orb</artifactId>
- <version>4.2.2</version>
- </dependency>
- </dependencies>
- </profile>
-
- <!--
- TODO: Please remove, temporary repository settings in order to
enable snapshots for
- Spring Boot 3.0.0
- -->
- <profile>
- <id>jakarta</id>
Review Comment:
I think when profiles are used explicitly (like fe `-P`), the
`activeByDefault` is not respected (since it is not default anymore). If you
are curious, it is simple to check:
```
$ mvn help:active-profiles
```
vs explicit profiles with `-P` (this command fails for me, the `jakarta`
profile is not picked up anymore)
```
$ mvn help:active-profiles -Peverything
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
