reta commented on code in PR #1836:
URL: https://github.com/apache/cxf/pull/1836#discussion_r1581891218
##########
services/xkms/xkms-x509-handlers/src/test/java/org/apache/cxf/xkms/x509/validator/TrustedAuthorityValidatorCRLTest.java:
##########
@@ -91,8 +91,12 @@ public void testIsCertChainValid() throws
CertificateException {
validator.isCertificateChainValid(Arrays.asList(certificateRoot)));
Assert.assertTrue("wss40rev should not be valid",
!validator.isCertificateChainValid(Arrays.asList(certificateWss40Rev)));
- Assert.assertTrue("wss40 should be valid",
-
validator.isCertificateChainValid(Arrays.asList(certificateWss40)));
+ //Red Hat OpenJDK must have RSA keySize 2048 or greater.
+ //see jdk.certpath.disabledAlgorithms=MD2, SHA1, MD5, DSA, RSA keySize
< 2048
Review Comment:
@jgoodyear I am wondering if this should be really treated as RedHat
specific vs checking the `AlgorithmConstraints`:
```
final AlgorithmConstraints disabledAlgConstraints =
new
DisabledAlgorithmConstraints(PROPERTY_CERTPATH_DISABLED_ALGS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
