reta commented on code in PR #2253:
URL: https://github.com/apache/cxf/pull/2253#discussion_r1939890588
##########
integration/jca/src/main/java/org/apache/cxf/jca/core/classloader/PlugInClassLoader.java:
##########
@@ -95,7 +95,7 @@ private static Properties getProperties(ClassLoader parent,
String propsFileName
props.load(in);
LOG.fine("Contents: " + propsFileName + props);
-
+ in.close();
Review Comment:
Could we wrap it in `try(InputStream in =
parent.getResourceAsStream(propsFileName)) {...}` please?
##########
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js:
##########
@@ -540,7 +540,7 @@ function org_apache_cxf_pad_string(string, len, pad, type) {
pad = typeof(pad) == 'string' ? pad : ' ';
if (type == org_apache_cxf_pad_string_PAD_BOTH) {
- string = org_apache_cxf_pad_sring(Math.floor(len / 2) +
string.length,
+ string = org_apache_cxf_pad_string(Math.floor(len / 2) +
string.length,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
