reta commented on code in PR #2275:
URL: https://github.com/apache/cxf/pull/2275#discussion_r1960192231
##########
core/src/main/java/org/apache/cxf/io/DelayedCachedOutputStreamCleaner.java:
##########
@@ -167,7 +167,8 @@ public boolean equals(Object obj) {
}
final DelayedCloseable other = (DelayedCloseable) obj;
- return Objects.equals(closeable, other.closeable);
+ // because of the broken Liskov Substitution Principle, check in
two ways to find equal streams
+ return Objects.equals(other.closeable, closeable) ||
Objects.equals(closeable, other.closeable);
Review Comment:
Thank you @yurkom , this is clearly violates the `equals` contract, I
believe we need to find out why and fix the root cause of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
