github-advanced-security[bot] commented on code in PR #3054:
URL: https://github.com/apache/cxf/pull/3054#discussion_r3130056484
##########
rt/ws/security/src/main/java/org/apache/cxf/ws/security/trust/AbstractSTSClient.java:
##########
@@ -614,7 +620,22 @@
}
}
- private Element downloadSchema(String schemaLocation) throws Exception {
+ protected Element getSchemaElement(MetadataSection s) throws Exception {
+ Element schemaElement = (Element)s.getAny();
+ if (schemaElement == null) {
+ if (!allowMexMetadataSchemaLocation) {
+ LOG.info("Loading a schema from WS-MEX MetadataSection
Location is disabled by "
+ + " default. Enable allowMexMetadataSchemaLocation to
allow it.");
+ } else {
+ String schemaLocation = s.getLocation();
+ LOG.info("XSD schema location: " + schemaLocation);
Review Comment:
## CodeQL / Insertion of sensitive information into log files
This [potentially sensitive information](1) is written to a log file.
[Show more
details](https://github.com/apache/cxf/security/code-scanning/2214)
##########
rt/ws/security/src/main/java/org/apache/cxf/ws/security/trust/AbstractSTSClient.java:
##########
@@ -614,7 +620,22 @@
}
}
- private Element downloadSchema(String schemaLocation) throws Exception {
+ protected Element getSchemaElement(MetadataSection s) throws Exception {
+ Element schemaElement = (Element)s.getAny();
+ if (schemaElement == null) {
+ if (!allowMexMetadataSchemaLocation) {
+ LOG.info("Loading a schema from WS-MEX MetadataSection
Location is disabled by "
+ + " default. Enable allowMexMetadataSchemaLocation to
allow it.");
+ } else {
+ String schemaLocation = s.getLocation();
+ LOG.info("XSD schema location: " + schemaLocation);
Review Comment:
## CodeQL / Log Injection
This log entry depends on a [user-provided value](1).
This log entry depends on a [user-provided value](2).
This log entry depends on a [user-provided value](3).
[Show more
details](https://github.com/apache/cxf/security/code-scanning/2215)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
