reta commented on code in PR #3168:
URL: https://github.com/apache/cxf/pull/3168#discussion_r3341163218
##########
rt/rs/extensions/json-basic/src/main/java/org/apache/cxf/jaxrs/json/basic/JsonMapObjectReaderWriter.java:
##########
@@ -285,6 +285,10 @@ private List<Object> internalFromJsonAsList(String name,
String json, int depth)
readJsonObjectAsSettable(nextMap, json.substring(i + 1,
closingIndex), depth + 1);
values.add(nextMap.map);
i = closingIndex + 1;
+ } else if (json.charAt(i) == ARRAY_START) {
+ int closingIndex = getClosingIndex(json, ARRAY_START,
ARRAY_END, i);
+ values.add(internalFromJsonAsList(name, json.substring(i + 1,
closingIndex), depth + 1));
Review Comment:
Just wondering if we could be dealing with invalid json by being defensive
here:
```suggestion
if (closingIndex == -1) {
throw new UncheckedIOException(new IOException("Error in
parsing json"));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
