vp340 commented on code in PR #3373:
URL: https://github.com/apache/cxf/pull/3373#discussion_r3839279575
##########
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/LoggingInInterceptor.java:
##########
@@ -71,6 +73,9 @@ public LoggingInInterceptor(PrintWriter writer) {
public LoggingInInterceptor(LogEventSender sender) {
super(Phase.PRE_INVOKE, sender);
+
+ //Make sure that the LIVE_LOGGING_PROP won't be propagated into the
ResponseContext from IN Messages
+ addResponseContextExcludedInProperty(LIVE_LOGGING_PROP);
Review Comment:
Hi @reta ,
Yeah the camel CXF wrapper does :
// make sure the "requestor role" property does not get propagated as we do
switch role
responseContext.remove(Message.REQUESTOR_ROLE);
outMessage.putAll(responseContext);
// Do we still need to put the response context back like this
outMessage.put(CxfConstants.RESPONSE_CONTEXT, responseContext);
...
but as we said for the cxf core module, being the LIVE_LOGGING_PROP
protected the camel module is not aware of it so it can't remove it like it
does with Message.REQUESTOR_ROLE .
The only way would be adding a white-list there, but as U said (and I fully
agree) for this side log feature your simple fix is more than enough as long as
we see the RESP_OUT log. :)
I'll leave it up to U whether it's worth pursuing a Camel-side fix as well,
but as long as it doesn't emerge a more tricky problem with the propagation of
the response context ...I don't find it really necessary and could be also
risky.
Thanks for all the time U dedicated to this problem.
See U in the next one (hopefully not ;) ... )
Keep up the great work!
Valentino Porta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
