reta commented on code in PR #3552:
URL: https://github.com/apache/cxf/pull/3552#discussion_r4209593916
##########
core/src/main/java/org/apache/cxf/endpoint/ClientImpl.java:
##########
@@ -138,11 +138,14 @@ public ClientImpl(Bus bus, Service svc, QName port,
EndpointInfo epfo = findEndpoint(svc, port);
try {
+ final Endpoint ep;
if (endpointImplFactory != null) {
-
getConduitSelector().setEndpoint(endpointImplFactory.newEndpointImpl(bus, svc,
epfo));
+ ep = endpointImplFactory.newEndpointImpl(bus, svc, epfo);
} else {
- getConduitSelector().setEndpoint(new EndpointImpl(bus, svc,
epfo));
+ ep = new EndpointImpl(bus, svc, epfo);
}
+ svc.getEndpoints().put(epfo.getName(), ep);
Review Comment:
Super minor:
```suggestion
svc.getEndpoints().put(epfo.getName(), ep);
epfo.getService().addEndpoint(ep);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
