rootvector2 opened a new pull request, #3654: URL: https://github.com/apache/cxf/pull/3654
`SamlFormInHandler.filter` answers 302 to the `RelayState` form value whenever it does not start with the service base URI, so once any valid `SAMLToken` is posted, an off-site value like `https://evil.example.com/` or `https://[email protected]/` is exactly what gets redirected, an open redirect since `RelayState` is not covered by the assertion signature (the handler keeps form values encoded, so the value has to be sent raw, e.g. from a `text/plain` form or a non-browser client). Found while reviewing the redirect paths in the SAML handlers: the redirect now only happens for a relative location or one with the same scheme and authority as the base URI, other values are ignored and the request continues, and the off-host cases in the new `SamlFormInHandlerTest` fail on the current tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
