stevedlawrence commented on a change in pull request #16: Implemented packed binary formats URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r161789191
########## File path: daffodil-lib/src/main/scala/edu/illinois/ncsa/daffodil/util/DecimalUtils.scala ########## @@ -0,0 +1,342 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package edu.illinois.ncsa.daffodil.util + +import edu.illinois.ncsa.daffodil.schema.annotation.props.gen.BinaryNumberCheckPolicy + +import java.math.{ BigInteger => JBigInteger, BigDecimal => JBigDecimal } + +object DecimalUtils { + + def signCodesToHex(signCodes: String, policy: BinaryNumberCheckPolicy): Map[String, List[Int]] = { + // remove all spaces from the string + val str: String = signCodes.replaceAll("\\s", "") + val chars: Array[Char] = str.toCharArray() Review comment: This isn't quite right. For example, if you did ``dfdl:binaryPackedSignCodes="A BCD"`` this would work, even though it isn't valid (must be 4 space separated characters). You might want to create a new Cooker (in Cookers.scala) based on the ListOfSingleCharacterLiteralNoCharClassEntitiesNoByteEntities, which will ensure that there is a list of characters only, there are no character entities, and will convert to a Seq of chars for you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
